-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG and version mapping for v1.4.3 #643
Conversation
CHANGELOG.md
Outdated
|
||
# Change Log | ||
|
||
## [v1.4.3](https://github.com/kubernetes/ingress-gce/tree/v1.4.3) (2019-02-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we have two v1.4.3 sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I ran the tool multiple times and it seems to have appended. Fixed.
CHANGELOG.md
Outdated
|
||
# Change Log | ||
|
||
## [v1.4.3](https://github.com/kubernetes/ingress-gce/tree/v1.4.3) (2019-02-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Humm..Actually three
CHANGELOG.md
Outdated
**Implemented enhancements:** | ||
|
||
- BackendConfig security policy not enforced [\#616](https://github.com/kubernetes/ingress-gce/issues/616) | ||
- original http request origin and host headers are overriden [\#179](https://github.com/kubernetes/ingress-gce/issues/179) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two might not be implemented enhancements?
b9fc043
to
9371232
Compare
9371232
to
c0ef3cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @MrHohn