Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod Readiness Reflector #711

Closed
wants to merge 1 commit into from
Closed

Pod Readiness Reflector #711

wants to merge 1 commit into from

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Apr 4, 2019 •
edited
Loading

Package /pkg/neg/readiness included all logic related to the readiness reflector
No additional unit tests are added.
Only include unit test fixes.
Will break up to multiple commits.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin April 4, 2019 00:15
@kubernetes kubernetes deleted a comment Apr 4, 2019
@freehan freehan force-pushed the readiness-reflector2 branch from f3f3c1a to 2762f6e Compare April 11, 2019 23:55
@freehan freehan force-pushed the readiness-reflector2 branch 2 times, most recently from ddad928 to bb5c4e6 Compare April 24, 2019 23:36
@freehan freehan changed the title WIP: readiness reflector Pod Readiness Reflector Apr 24, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2019
@freehan freehan force-pushed the readiness-reflector2 branch from bb5c4e6 to a64fe5b Compare April 25, 2019 00:44
@freehan freehan force-pushed the readiness-reflector2 branch from a64fe5b to 0c59b92 Compare April 26, 2019 00:12
@k8s-ci-robot
Copy link
Contributor

@freehan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-gce-test 0c59b92 link /test pull-ingress-gce-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bowei
Copy link
Member

bowei commented May 6, 2019

wait -- which one is the right one to review?

@freehan
Copy link
Contributor Author

freehan commented May 14, 2019

close in favor of #748

@freehan freehan closed this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freehan @k8s-ci-robot @bowei