-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use GlobalForwardingRules().Get() when detected a global fw rule #778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let us know if the local test passes :)
_, err := c.ForwardingRules().Get(ctx, &k) | ||
var fwRuleError error | ||
if k.Region != "" { | ||
_, err = c.ForwardingRules().Get(ctx, &k) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we can just change all ForwardingRule to GlobalForwardingRule... but, anyway, let me try to fix test first...
I think this has the value, once we have L7 internal LB, forwarding rule might be regional.
fixed tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, MrHohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I feel like we can just change all
ForwardingRule
toGlobalForwardingRule
... but, anyway, let me try to fix test first...Still unsure why it works for prod though.
/assign @MrHohn @rramkumar1