Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update websocket example #80

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Update websocket example #80

merged 1 commit into from
Dec 11, 2017

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Dec 7, 2017 •
edited
Loading

Changes:

  • Fixes occasional panics due to concurrent writing
  • Adds html page for connecting to the websocket
  • Adds copyright header

Fixes #77

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
bowei
bowei reviewed Dec 9, 2017
View reviewed changes
examples/websocket/README.md Outdated
Successfully built eecd0574e5d1

➜ docker push nicksardo/websocketexample:latest
➜ docker build -t nicksardo/websocketexample:v1 .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need your docker in the example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had it for convenience. Removed.

@bowei
Copy link
Member

bowei commented Dec 9, 2017

lgtm

@nicksardo nicksardo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2017
@nicksardo nicksardo merged commit 1590093 into kubernetes:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

Assignees

@bowei bowei

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicksardo @bowei @k8s-ci-robot