Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LB GC #819

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Refactor LB GC #819

merged 2 commits into from
Aug 12, 2019

Conversation

spencerhance
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn August 9, 2019 04:11
@spencerhance spencerhance force-pushed the refactor-lb-gc branch 2 times, most recently from 085ee9f to 573d616 Compare August 9, 2019 04:13
@bowei
Copy link
Member

bowei commented Aug 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
bowei
bowei reviewed Aug 12, 2019
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things

pkg/loadbalancers/l7s.go Outdated
if err != nil {
return nil, nil, err
return nil, fmt.Errorf("error listing url maps: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pass the error through

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/loadbalancers/l7s.go
}
}

urlMaps, err := l.List(meta.GlobalKey(""), meta.VersionGA)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fix List taking a Key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/loadbalancers/l7s.go
nameParts := l.namer.ParseName(um.Name)
l7Name := l.namer.LoadBalancerFromLbName(nameParts.LbName)

if knownLoadBalancers.Has(l7Name) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if known... {
log.V(3).Infof("Load balancer %v is still valid, not GC'ing", l7Name)
continue
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/loadbalancers/l7s.go Outdated
return fmt.Errorf("error listing global LBs: %v", err)
}

if errors := l.gc(urlMaps, knownLoadBalancers, features.NewResourceVersions()); errors != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably alias var GAResourceVersions = NewResourceVersions() in the features package to make this more understandable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

bowei
bowei reviewed Aug 12, 2019
View reviewed changes
pkg/loadbalancers/features/features.go
@@ -28,6 +28,8 @@ const (
FeatureL7ILB = "L7ILB"
)

var GAResourceVersions = NewResourceVersions()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc string

@bowei
Copy link
Member

bowei commented Aug 12, 2019

/lgtm
/approve

you need to fix golint

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4b9ca48 into kubernetes:master Aug 12, 2019
@spencerhance spencerhance deleted the refactor-lb-gc branch September 27, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerhance @k8s-ci-robot @bowei