Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test framework add support for ilb subnet #846

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Sep 10, 2019

Adds support for creating and deleting ilb subnets to the e2e test framwork
Also adds optional "region" CLI flag to e2e binary which is needed for the subnet
Region will also be necessary for part 2 of the e2e test framework changes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2019
@bowei
Copy link
Member

bowei commented Sep 10, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2019
@spencerhance
Copy link
Contributor Author

/assign @bowei

cmd/e2e-test/main_test.go Outdated Show resolved Hide resolved
cmd/e2e-test/run.sh Outdated Show resolved Hide resolved
cmd/e2e-test/run.sh Outdated Show resolved Hide resolved
cmd/e2e-test/run.sh Outdated Show resolved Hide resolved
cmd/e2e-test/run.sh Outdated Show resolved Hide resolved
pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
@spencerhance
Copy link
Contributor Author

@bowei Following up on this. We really should be using this in the e2e tests.

pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
@bowei
Copy link
Member

bowei commented Sep 25, 2019

Small nit, otherwise lgtm

Adds support for creating and deleting ilb subnets to the e2e test framwork
Also adds "region" CLI flag to e2e binary which is needed for the subnet
@bowei
Copy link
Member

bowei commented Sep 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8efbf67 into kubernetes:master Sep 25, 2019
@spencerhance spencerhance deleted the add-ilb-e2e-tests branch September 27, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants