-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e test framework add support for ilb subnet #846
e2e test framework add support for ilb subnet #846
Conversation
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
6e3eec0
to
2495e9f
Compare
/assign @bowei |
2495e9f
to
dd93d89
Compare
@bowei Following up on this. We really should be using this in the e2e tests. |
Small nit, otherwise lgtm |
dd93d89
to
d3e87c5
Compare
Adds support for creating and deleting ilb subnets to the e2e test framwork Also adds "region" CLI flag to e2e binary which is needed for the subnet
d3e87c5
to
9bd434f
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds support for creating and deleting ilb subnets to the e2e test framwork
Also adds optional "region" CLI flag to e2e binary which is needed for the subnet
Region will also be necessary for part 2 of the e2e test framework changes