split the error message in backend syncer health processing #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
cc @skmatti |
rramkumar1
reviewed
Sep 24, 2019
pkg/backends/backends.go
Outdated
| @@ -163,7 +163,7 @@ func (b *Backends) Delete(name string, version meta.Version, scope meta.KeyType) | |||
| func (b *Backends) Health(name string, version meta.Version, scope meta.KeyType) (string, error) { | |||
| be, err := b.Get(name, version, scope) | |||
| if err != nil || len(be.Backends) == 0 { | |||
| return "Unknown", fmt.Errorf("error getting health for backend %s: %v", name, err) | |||
| return "Unknown", fmt.Errorf("error getting backend %s: %v", name, err) | |||
There was a problem hiding this comment.
%q. Same below as well.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: freehan, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bowei
reviewed
Sep 24, 2019
| @@ -163,7 +163,7 @@ func (b *Backends) Delete(name string, version meta.Version, scope meta.KeyType) | |||
| func (b *Backends) Health(name string, version meta.Version, scope meta.KeyType) (string, error) { | |||
| be, err := b.Get(name, version, scope) | |||
| if err != nil || len(be.Backends) == 0 { | |||
| return "Unknown", fmt.Errorf("error getting health for backend %s: %v", name, err) | |||
| return "Unknown", fmt.Errorf("error getting backend %q: %v", name, err) | |||
There was a problem hiding this comment.
can we separate out the cases here
if err != nil {
return "Unknown", fmt.Errorf("error betting backend...", ...)
}
if len(be.Backends) == 0 {
return "Unknown", fmt.Errorf("backend list is empty...", ...)
}
| return "Unknown", fmt.Errorf("error getting health for backend %q: %v", name, err) | ||
| } | ||
| if len(hs.HealthStatus) == 0 || hs.HealthStatus[0] == nil { |
There was a problem hiding this comment.
Why would we get a nil in the first element? seems incorrect (somewhere).
rramkumar1
removed
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first sync for an ingress, this log line usually gets emitted:
Usually shortly after Backends are attached to Backend-Services, there is no health status. Hence result in the log line.