Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1.5.2, v1.6.0 and v1.7.0 to CHANGELOG.md #887

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Add v1.5.2, v1.6.0 and v1.7.0 to CHANGELOG.md #887

merged 1 commit into from
Oct 8, 2019

Conversation

spencerhance
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2019
@spencerhance
Copy link
Contributor Author

/assign @rramkumar1

@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin October 5, 2019 03:23
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2019
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2019
@rramkumar1
Copy link
Contributor

@spencerhance I think this is missing some PR's?

We had a lot of stuff go into 1.6

@bowei
Copy link
Member

bowei commented Oct 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2019
@rramkumar1
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2019
@spencerhance spencerhance changed the title Add v1.5.2 and v1.6.0 to CHANGELOG.md Add v1.5.2, v1.6.0 and v1.7.0 to CHANGELOG.md Oct 8, 2019
@spencerhance
Copy link
Contributor Author

@rramkumar1 Updated

rramkumar1
rramkumar1 reviewed Oct 8, 2019
View reviewed changes
CHANGELOG.md Outdated
- Add e2e test for Ingress that has long namespace+name [\#689](https://github.com/kubernetes/ingress-gce/pull/689) ([rramkumar1](https://github.com/rramkumar1))
- Port basic NEG test from k/k [\#679](https://github.com/kubernetes/ingress-gce/pull/679) ([spencerhance](https://github.com/spencerhance))
- Add tests for HTTPS [\#671](https://github.com/kubernetes/ingress-gce/pull/671) ([rramkumar1](https://github.com/rramkumar1))
- Move tests for app protocols from k/k to Ingress-GCE repo [\#668](https://github.com/kubernetes/ingress-gce/pull/668) ([rramkumar1](https://github.com/rramkumar1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come some PR's got skipped? Like 670 for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned out most of those PRs were extraneous, fixed now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by extraneous? I still don't see 670.

Copy link
Contributor Author

@spencerhance spencerhance Oct 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, there were a ton of PRs under 1.5.2 that weren't actually added in that version, so I removed them.

I believe the numbers being skipped refer to closed PRs and open issues

This is 670: #670

CHANGELOG.md Outdated
@@ -756,4 +950,10 @@



\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the excess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@spencerhance spencerhance force-pushed the update-changelog branch 2 times, most recently from 3d7547e to 855ee9e Compare October 8, 2019 21:35
@spencerhance
Copy link
Contributor Author

@rramkumar1 updated

@rramkumar1
Copy link
Contributor

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 473bc87 into kubernetes:master Oct 8, 2019
@rramkumar1 rramkumar1 mentioned this pull request Oct 8, 2019
Closed
@spencerhance spencerhance deleted the update-changelog branch October 8, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerhance @k8s-ci-robot @rramkumar1 @bowei