Support more methods in composite NEGs. #923
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
@spencerhance @freehan PTAL when you get a chance, thanks! |
|
/assign @freehan |
NEG syncer code requires AggregatedList and ListNetworkEndpoints api.
prameshj
force-pushed
the
composite-neg
branch
from
fcbb505 to
c1d97eb
Compare
|
@freehan can you take a look since I can't approve this? |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: freehan, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -501,6 +501,13 @@ type BackendServiceLogConfig struct { | |||
| NullFields []string `json:"-"` | |||
| } | |||
|
|
|||
| // BackendServiceReference is a composite type wrapping the Alpha, Beta, and GA methods for its GCE equivalent | |||
| type BackendServiceReference struct { | |||
There was a problem hiding this comment.
I assume this is a new struct from the GCE go client?
There was a problem hiding this comment.
The new struct here is because it is referenced in the "HealthStatusForNetworkEndpoint" which is part of the output for the ListNetworkEndpoints call.
Existing neg utils require ListNetworkEndpoints and AggregatedListNetworkEndpointGroup. This PR adds those 2 methods to composite types.