Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out on invalid ingress frontend configuration #950

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Error out on invalid ingress frontend configuration #950

merged 1 commit into from
Nov 20, 2019

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Nov 19, 2019 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2019
@skmatti skmatti mentioned this pull request Nov 19, 2019
Merged
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2019
rramkumar1
rramkumar1 reviewed Nov 19, 2019
View reviewed changes
pkg/loadbalancers/l7.go Outdated Show resolved Hide resolved
rramkumar1
rramkumar1 reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@rramkumar1 rramkumar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @MrHohn for a sanity check.

pkg/loadbalancers/l7.go Outdated Show resolved Hide resolved
pkg/loadbalancers/l7.go
@@ -196,11 +197,6 @@ func (l *L7) edgeHop() error {
}
klog.V(2).Infof("Successfully deleted unused HTTPS frontend resources for load-balancer %s", l)
}

if !willConfigureFrontend {
l.recorder.Eventf(l.runtimeInfo.Ingress, corev1.EventTypeNormal, "WillNotConfigureFrontend", "Will not configure frontend based on Ingress specification. Please check your usage of the 'kubernetes.io/ingress.allow-http' annotation.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the error message here is much better than what you have now. Can you try to incorporate some of this in to the new message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@skmatti skmatti changed the title Return an error on invalid ingress frontend configuration Error out on invalid ingress frontend configuration Nov 20, 2019
@rramkumar1
Copy link
Contributor

LGTM

/assign @MrHohn for sanity check.

MrHohn
MrHohn approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I like this better than the previous behavior.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit fb4245f into kubernetes:master Nov 20, 2019
@skmatti skmatti mentioned this pull request Nov 21, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 21, 2019
@k8s-ci-robot
Merge pull request #954 from skmatti/cherrypick-l7-fix
8c4e8b7 
Cherrypick #950 into release 1.8
@skmatti skmatti deleted the l7s-fix branch November 22, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

@freehan freehan Awaiting requested review from freehan

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmatti @k8s-ci-robot @rramkumar1 @MrHohn