Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Finalizer upgrade test to use the upgrade framework #952

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Migrate Finalizer upgrade test to use the upgrade framework #952

merged 1 commit into from
Nov 22, 2019

Conversation

skmatti
Copy link
Contributor

@skmatti skmatti commented Nov 20, 2019 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @skmatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 20, 2019
@skmatti skmatti force-pushed the finalizer-upgrade-test-cleanup branch from f4731d9 to a956f29 Compare November 20, 2019 06:29
@skmatti skmatti mentioned this pull request Nov 20, 2019
Merged
@skmatti
Copy link
Contributor Author

skmatti commented Nov 20, 2019

/assign @rramkumar1 @MrHohn

@MrHohn
Copy link
Member

MrHohn commented Nov 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2019
@skmatti skmatti force-pushed the finalizer-upgrade-test-cleanup branch from a956f29 to df0f7d7 Compare November 21, 2019 21:00
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 21, 2019
rramkumar1
rramkumar1 reviewed Nov 21, 2019
View reviewed changes
cmd/e2e-test/upgrade/finalizer.go Outdated Show resolved Hide resolved
cmd/e2e-test/upgrade_test.go Outdated Show resolved Hide resolved
cmd/e2e-test/upgrade_test.go Outdated Show resolved Hide resolved
@skmatti skmatti force-pushed the finalizer-upgrade-test-cleanup branch 2 times, most recently from 025a865 to de2852d Compare November 21, 2019 23:24
@rramkumar1
Copy link
Contributor

Looks good to me. Will officially approve once that last comment is addressed.

@skmatti skmatti force-pushed the finalizer-upgrade-test-cleanup branch from de2852d to 628bddd Compare November 22, 2019 00:20
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rramkumar1, skmatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5dd7e68 into kubernetes:master Nov 22, 2019
@skmatti skmatti deleted the finalizer-upgrade-test-cleanup branch November 22, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@bowei bowei Awaiting requested review from bowei

@freehan freehan Awaiting requested review from freehan

Assignees

@MrHohn MrHohn

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skmatti @k8s-ci-robot @MrHohn @rramkumar1