Add NEG mocks for alpha API and a new transactions test #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added conversion functions from composite to compute for NetworkEndpoint and other resources.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
pkg/neg/readiness/poller_test.go
Outdated
| "net" | ||
| "strconv" | ||
| "testing" | ||
|
|
||
| "k8s.io/ingress-gce/pkg/composite" |
There was a problem hiding this comment.
Can you move this to the group below?
pkg/neg/syncers/transaction_test.go
Outdated
| if err != nil { | ||
| t.Errorf("For case %q,, endpointSets error == nil, but got %v", tc.desc, err) | ||
| t.Errorf("For case %q, endpointSets error == nil, but got %v", tc.desc, err) |
There was a problem hiding this comment.
Might make sense to update this error to something like
t.Errorf("desc: %q, syncNetworkEndpoints() = %v, want nil", tc.desc. err)Same with below
There was a problem hiding this comment.
Yes, the new log message is much clearer, fixed.
pkg/neg/types/mock.go
Outdated
| @@ -192,21 +332,26 @@ func MockDetachNetworkEndpointsHook(ctx context.Context, key *meta.Key, obj *com | |||
| return nil | |||
| } | |||
|
|
|||
| func isNetworkEndpointsEqual(left, right *compute.NetworkEndpoint) bool { | |||
| func toComposite(input interface{}) *composite.NetworkEndpoint { | |||
There was a problem hiding this comment.
Might make sense to just use the composite function directly and not eat the err here
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables creation of NEGs in unit tests using Alpha or GA api. The transactions test has been modified to create both VM_IP_PORT as well as PRIMARY_VM_IP negs.