Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegionalGCLBForVIP() Fix #969

Merged
merged 2 commits into from
Dec 20, 2019
Merged

RegionalGCLBForVIP() Fix #969

merged 2 commits into from
Dec 20, 2019

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Dec 7, 2019 •
edited
Loading

Fixes a bug where the ilb e2e test helper function may confuse multiple forwarding rules
from different VPCs with the same VIP

Will require another PR first to add the network flag to internal tests
/hold

Blocked by #971

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2019
@spencerhance
RegionalGCLBForVIP() Fix
910d9ca 
Fixes a bug where the ilb e2e test helper function may confuse multiple forwarding rules
from different VPCs with the same VIP
@spencerhance spencerhance force-pushed the fix-ilb-e2e-test-vip-bug branch from c3eb7c1 to 910d9ca Compare December 20, 2019 18:36
@spencerhance
Copy link
Contributor Author

/assign @freehan

@spencerhance
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2019
@freehan
Copy link
Contributor

freehan commented Dec 20, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2019
freehan
freehan reviewed Dec 20, 2019
View reviewed changes
pkg/fuzz/gcp.go Outdated
@@ -398,6 +399,7 @@ func GCLBForVIP(ctx context.Context, c cloud.Cloud, params *GCLBForVIPParams) (*
if err := RegionalGCLBForVIP(ctx, c, gclb, params); err != nil {
return nil, err
}
return gclb, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

err := RegionalGCLBForVIP(.....
return gclb, err

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh much nicer, fixed

@spencerhance spencerhance force-pushed the fix-ilb-e2e-test-vip-bug branch from 0c32528 to 01a1808 Compare December 20, 2019 22:31
freehan
freehan approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1d46157 into kubernetes:master Dec 20, 2019
@spencerhance spencerhance deleted the fix-ilb-e2e-test-vip-bug branch June 29, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freehan freehan freehan approved these changes

@MrHohn MrHohn Awaiting requested review from MrHohn

@thockin thockin Awaiting requested review from thockin

Assignees

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerhance @k8s-ci-robot @freehan