Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createIlbSubnet flag to ilb e2e tests #970

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Add createIlbSubnet flag to ilb e2e tests #970

merged 1 commit into from
Dec 16, 2019

Conversation

spencerhance
Copy link
Contributor

Now used in addition to -network since all ilb tests will need -network
for GCLBForVIP()

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn December 7, 2019 01:49
@spencerhance spencerhance mentioned this pull request Dec 7, 2019
Merged
@bowei
Copy link
Member

bowei commented Dec 7, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2019
bowei
bowei reviewed Dec 7, 2019
View reviewed changes
cmd/e2e-test/main_test.go Outdated Show resolved Hide resolved
pkg/e2e/fixtures.go Outdated
@@ -264,10 +264,10 @@ func DeleteGCPAddress(s *Sandbox, name string) error {

// CreateILBSubnet creates the ILB subnet
func CreateILBSubnet(s *Sandbox) error {
klog.V(3).Info("CreateILBSubnet()")
klog.V(4).Info("CreateILBSubnet()")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this V(2) actually? Do we actually expect this to be printed a lot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/e2e/fixtures.go Outdated Show resolved Hide resolved
@spencerhance spencerhance force-pushed the ilb-e2e-subnet-creation-flag branch from e0a988c to 4f77631 Compare December 9, 2019 21:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2019
@spencerhance spencerhance force-pushed the ilb-e2e-subnet-creation-flag branch from 4f77631 to 8d748a2 Compare December 9, 2019 21:07
@spencerhance
Copy link
Contributor Author

blocking #971

@spencerhance
Copy link
Contributor Author

@bowei can you take another look?

bowei
bowei reviewed Dec 13, 2019
View reviewed changes
cmd/e2e-test/main_test.go
if flags.network == "" {
klog.Info("No network provided, will not create ILB Subnet")
// TODO(shance): Make this a required flag, error out here
fmt.Println("-network must be set to the network of the cluster")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not follow spencer's comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I can't make it a required flag yet since the code to add the network is in another PR

bowei
bowei reviewed Dec 13, 2019
View reviewed changes
cmd/e2e-test/ilb_test.go Outdated
t.Fatalf("error ensuring regional subnet for ILB: %v", err)
if Framework.CreateILBSubnet {
if err := e2e.CreateILBSubnet(s); err != nil && err != e2e.ErrSubnetExists {
t.Fatalf("error ensuring regional subnet for ILB: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better just to do

t.Fatalf("e2e.CreateILBSubnet(%+v) = %v", ...) so it's easier to debug

fix all instances below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bowei
Copy link
Member

bowei commented Dec 13, 2019

reviewed --- small stuff

@spencerhance
Add createIlbSubnet flag to ilb e2e tests
5e3589f 
Now used in addition to -network since all ilb tests will need -network
for GCLBForVIP()
@spencerhance spencerhance force-pushed the ilb-e2e-subnet-creation-flag branch from 8d748a2 to 5e3589f Compare December 16, 2019 22:41
@bowei
Copy link
Member

bowei commented Dec 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit adb33c8 into kubernetes:master Dec 16, 2019
@spencerhance spencerhance deleted the ilb-e2e-subnet-creation-flag branch June 29, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerhance @k8s-ci-robot @bowei