Merge pull request #722 from aledbf/remove-go-reaper

Remove go-reap and use tini as process reaper
kubernetes · May 17, 2017 · b4032f0 · b4032f0
2 parents bc6112b + 22d63d0
commit b4032f0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/controllers/nginx/pkg/cmd/controller/main.go b/controllers/nginx/pkg/cmd/controller/main.go
@@ -23,14 +23,10 @@ import (
 	"time"
 
 	"github.com/golang/glog"
-	go_reap "github.com/hashicorp/go-reap"
-
 	"k8s.io/ingress/core/pkg/ingress/controller"
 )
 
 func main() {
-	go go_reap.ReapChildren(nil, nil, nil, nil)
-
 	// start a new nginx controller
 	ngx := newNGINXController()
 	// create a custom Ingress controller using NGINX as backend

diff --git a/controllers/nginx/pkg/cmd/controller/nginx.go b/controllers/nginx/pkg/cmd/controller/nginx.go
@@ -53,8 +53,6 @@ const (
 
 	defaultStatusModule statusModule = "default"
 	vtsStatusModule     statusModule = "vts"
-
-	errNoChild = "wait: no child processes"
 )
 
 var (
@@ -354,7 +352,7 @@ func (n NGINXController) testTemplate(cfg []byte) error {
 		return err
 	}
 	out, err := exec.Command(n.binary, "-t", "-c", tmpfile.Name()).CombinedOutput()
-	if err != nil && err.Error() != errNoChild {
+	if err != nil {
 		// this error is different from the rest because it must be clear why nginx is not working
 		oe := fmt.Sprintf(`
 -------------------------------------------------------------------------------

diff --git a/controllers/nginx/pkg/template/template.go b/controllers/nginx/pkg/template/template.go
@@ -40,7 +40,6 @@ import (
 const (
 	slash         = "/"
 	defBufferSize = 65535
-	errNoChild    = "wait: no child processes"
 )
 
 // Template ...
@@ -102,7 +101,7 @@ func (t *Template) Write(conf config.TemplateConfig) ([]byte, error) {
 	}
 
 	err := t.tmpl.Execute(t.tmplBuf, conf)
-	if err != nil && err.Error() != errNoChild {
+	if err != nil {
 		return nil, err
 	}
 
@@ -112,10 +111,7 @@ func (t *Template) Write(conf config.TemplateConfig) ([]byte, error) {
 	cmd.Stdin = t.tmplBuf
 	cmd.Stdout = t.outCmdBuf
 	if err := cmd.Run(); err != nil {
-		if err.Error() != errNoChild {
-			glog.Warningf("unexpected error cleaning template: %v", err)
-		}
-
+		glog.Warningf("unexpected error cleaning template: %v", err)
 		return t.tmplBuf.Bytes(), nil
 	}
 

diff --git a/controllers/nginx/rootfs/Dockerfile b/controllers/nginx/rootfs/Dockerfile
@@ -19,6 +19,11 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install -y \
   --no-install-recommends \
   && rm -rf /var/lib/apt/lists/*
 
+RUN curl -sSL -o /sbin/tini https://github.com/krallin/tini/releases/download/v0.14.0/tini-amd64 && \
+  chmod +x /sbin/tini
+
+ENTRYPOINT ["/sbin/tini", "--"]
+
 COPY . /
 
 CMD ["/nginx-ingress-controller"]