Merge pull request #2844 from aledbf/fix-latency

Do not allow invalid latency values in metrics
kubernetes · Jul 24, 2018 · bdb5ddc · bdb5ddc
2 parents 43aabfc + 010342a
commit bdb5ddc
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/internal/ingress/metric/collectors/socket.go b/internal/ingress/metric/collectors/socket.go
@@ -236,11 +236,13 @@ func (sc *SocketCollector) handleMessage(msg []byte) {
 		requestsMetric.Inc()
 	}
 
-	latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels)
-	if err != nil {
-		glog.Errorf("Error fetching latency metric: %v", err)
-	} else {
-		latencyMetric.Observe(stats.Latency)
+	if stats.Latency != -1 {
+		latencyMetric, err := sc.upstreamLatency.GetMetricWith(latencyLabels)
+		if err != nil {
+			glog.Errorf("Error fetching latency metric: %v", err)
+		} else {
+			latencyMetric.Observe(stats.Latency)
+		}
 	}
 
 	if stats.RequestTime != -1 {