Fix random watch errors

kubernetes · Jul 27, 2017 · dbe1880 · dbe1880
1 parent 16a213c
commit dbe1880
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/core/pkg/watch/file_watcher.go b/core/pkg/watch/file_watcher.go
@@ -19,6 +19,7 @@ package watch
 import (
 	"log"
 	"path"
+	"strings"
 
 	"gopkg.in/fsnotify.v1"
 )
@@ -42,7 +43,7 @@ func NewFileWatcher(file string, onEvent func()) (FileWatcher, error) {
 }
 
 // Close ends the watch
-func (f FileWatcher) Close() error {
+func (f *FileWatcher) Close() error {
 	return f.watcher.Close()
 }
 
@@ -59,9 +60,9 @@ func (f *FileWatcher) watch() error {
 		for {
 			select {
 			case event := <-watcher.Events:
-				if event.Op&fsnotify.Write == fsnotify.Write ||
-					event.Op&fsnotify.Create == fsnotify.Create &&
-						event.Name == file {
+				if (event.Op&fsnotify.Write == fsnotify.Write ||
+					event.Op&fsnotify.Create == fsnotify.Create) &&
+					strings.HasSuffix(event.Name, file) {
 					f.onEvent()
 				}
 			case err := <-watcher.Errors:

diff --git a/core/pkg/watch/file_watcher_test.go b/core/pkg/watch/file_watcher_test.go
@@ -26,7 +26,7 @@ import (
 func prepareTimeout() chan bool {
 	timeoutChan := make(chan bool, 1)
 	go func() {
-		time.Sleep(1 * time.Second)
+		time.Sleep(500 * time.Millisecond)
 		timeoutChan <- true
 	}()
 	return timeoutChan