Skip to content

Commit

Permalink
Merge pull request #3673 from moonming/table-new
Browse files Browse the repository at this point in the history
used table functions of LuaJIT for better performance.
  • Loading branch information
k8s-ci-robot authored Feb 1, 2019
2 parents e7e8d1a + a36961f commit eddbcc7
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions rootfs/etc/nginx/lua/monitor.lua
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
local socket = ngx.socket.tcp
local cjson = require("cjson.safe")
local assert = assert
local new_tab = require "table.new"
local clear_tab = require "table.clear"
local clone_tab = require "table.clone"

local metrics_batch = {}
-- if an Nginx worker processes more than (MAX_BATCH_SIZE/FLUSH_INTERVAL) RPS then it will start dropping metrics
local MAX_BATCH_SIZE = 10000
local FLUSH_INTERVAL = 1 -- second

local metrics_batch = new_tab(MAX_BATCH_SIZE, 0)

local _M = {}

local function send(payload)
Expand Down Expand Up @@ -46,8 +50,8 @@ local function flush(premature)
return
end

local current_metrics_batch = metrics_batch
metrics_batch = {}
local current_metrics_batch = clone_tab(metrics_batch)
clear_tab(metrics_batch)

local payload, err = cjson.encode(current_metrics_batch)
if not payload then
Expand All @@ -66,12 +70,13 @@ function _M.init_worker()
end

function _M.call()
if #metrics_batch >= MAX_BATCH_SIZE then
local metrics_size = #metrics_batch
if metrics_size >= MAX_BATCH_SIZE then
ngx.log(ngx.WARN, "omitting metrics for the request, current batch is full")
return
end

table.insert(metrics_batch, metrics())
metrics_batch[metrics_size + 1] = metrics()
end

if _TEST then
Expand Down

0 comments on commit eddbcc7

Please sign in to comment.