Missing e2e tests for ingress annotations

[diazjf]

This issue contains a list of all the required e2e test-cases for supported annotations:

Annotations:
- [ ] nginx.ingress.kubernetes.io/add-base-url
- [ ] nginx.ingress.kubernetes.io/app-root

• nginx.ingress.kubernetes.io/affinity
• nginx.ingress.kubernetes.io/auth-realm
• nginx.ingress.kubernetes.io/auth-secret
• nginx.ingress.kubernetes.io/auth-type
• nginx.ingress.kubernetes.io/auth-tls-secret
• nginx.ingress.kubernetes.io/auth-tls-verify-depth
• nginx.ingress.kubernetes.io/auth-tls-verify-client
• nginx.ingress.kubernetes.io/auth-tls-error-page
• nginx.ingress.kubernetes.io/auth-tls-pass-certificate-to-upstream
• nginx.ingress.kubernetes.io/auth-url
• nginx.ingress.kubernetes.io/auth-signin
• nginx.ingress.kubernetes.io/backend-protocol
  - [ ] nginx.ingress.kubernetes.io/base-url-scheme
• nginx.ingress.kubernetes.io/client-body-buffer-size
• nginx.ingress.kubernetes.io/configuration-snippet
• nginx.ingress.kubernetes.io/default-backend
• nginx.ingress.kubernetes.io/enable-cors
• nginx.ingress.kubernetes.io/cors-allow-origin
• nginx.ingress.kubernetes.io/cors-allow-methods
• nginx.ingress.kubernetes.io/cors-allow-headers
• nginx.ingress.kubernetes.io/cors-allow-credentials
• nginx.ingress.kubernetes.io/cors-max-age
• nginx.ingress.kubernetes.io/force-ssl-redirect
• nginx.ingress.kubernetes.io/from-to-www-redirect
  - [ ] nginx.ingress.kubernetes.io/grpc-backend
  - [ ] nginx.ingress.kubernetes.io/limit-connections
  - [ ] nginx.ingress.kubernetes.io/limit-rps
• nginx.ingress.kubernetes.io/permanent-redirect
• nginx.ingress.kubernetes.io/permanent-redirect-code
• nginx.ingress.kubernetes.io/proxy-body-size
• nginx.ingress.kubernetes.io/proxy-cookie-domain
• nginx.ingress.kubernetes.io/proxy-connect-timeout
• nginx.ingress.kubernetes.io/proxy-send-timeout
• nginx.ingress.kubernetes.io/proxy-read-timeout
• nginx.ingress.kubernetes.io/proxy-next-upstream
• nginx.ingress.kubernetes.io/proxy-next-upstream-tries
• nginx.ingress.kubernetes.io/proxy-request-buffering
• nginx.ingress.kubernetes.io/proxy-redirect-from
• nginx.ingress.kubernetes.io/proxy-redirect-to
• nginx.ingress.kubernetes.io/enable-rewrite-log
• nginx.ingress.kubernetes.io/rewrite-target
  - [ ] nginx.ingress.kubernetes.io/secure-backends
• nginx.ingress.kubernetes.io/secure-verify-ca-secret
• nginx.ingress.kubernetes.io/server-alias
• nginx.ingress.kubernetes.io/server-snippet
• nginx.ingress.kubernetes.io/service-upstream
• nginx.ingress.kubernetes.io/session-cookie-name
• nginx.ingress.kubernetes.io/session-cookie-hash
• nginx.ingress.kubernetes.io/ssl-redirect
• nginx.ingress.kubernetes.io/ssl-passthrough
  - [x] nginx.ingress.kubernetes.io/upstream-max-fails
  - [x] nginx.ingress.kubernetes.io/upstream-fail-timeout
  - [ ] nginx.ingress.kubernetes.io/upstream-hash-by
  - [ ] nginx.ingress.kubernetes.io/load-balance
• nginx.ingress.kubernetes.io/upstream-vhost
• nginx.ingress.kubernetes.io/whitelist-source-range
• nginx.ingress.kubernetes.io/proxy-buffering
• nginx.ingress.kubernetes.io/proxy-buffer-size
• nginx.ingress.kubernetes.io/ssl-ciphers
• nginx.ingress.kubernetes.io/connection-proxy-header
• nginx.ingress.kubernetes.io/enable-access-log
• nginx.ingress.kubernetes.io/lua-resty-waf
• nginx.ingress.kubernetes.io/lua-resty-waf-debug
• nginx.ingress.kubernetes.io/lua-resty-waf-ignore-rulesets
• nginx.ingress.kubernetes.io/lua-resty-waf-extra-rules
• nginx.ingress.kubernetes.io/enable-influxdb
• nginx.ingress.kubernetes.io/influxdb-measurement
• nginx.ingress.kubernetes.io/influxdb-port
• nginx.ingress.kubernetes.io/influxdb-host
• nginx.ingress.kubernetes.io/influxdb-server-name

[diazjf]

This one will knock out a few: #3149

[diazjf]

Adding #3151 to the list

[aledbf]

I removed secure-backends and grpc-backend because are being removed in #3203

[aledbf]

#3257

[aledbf]

#3262

[aledbf]

#3195

[aledbf]

#3277

[aledbf]

#3280

[aledbf]

#3281

[aledbf]

#3297

[aledbf]

add-base-url and base-url-scheme annotations will be removed in 0.22 (the support of regular expression make this "obsolete")

[ElvinEfendi]

add-base-url and base-url-scheme annotations will be removed in 0.22 (the support of regular expression make this "obsolete")

To clarify this was done because 1) it can be done in the app itself; 2) dropping that functionality enabled us simplify the hell out of rewrite logic in the controller: https://github.com/kubernetes/ingress-nginx/pull/3174/files; 3) it can be done using custom server snippet

[diazjf]

nginx.ingress.kubernetes.io/secure-verify-ca-secret in #3287

[diazjf]

Cleaning up:

Moved Ratelimiting annotation tests to #3401
Moved LoadBalance annotation tests to #3402

[diazjf]

• nginx.ingress.kubernetes.io/service-upstream
• nginx.ingress.kubernetes.io/ssl-passthrough
• nginx.ingress.kubernetes.io/lua-resty-waf-debug

are the last e2e needed which don't have a PR up.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.