-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Tracing collector failures should not cause ingress-nginx failure #7295
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Current Behavior
Currently having a failure within a jaeger trace collector results in ingress-nginx fully going down. Examples include the failure to resolve the
jaeger-endpoint
config key and inability to connect to the port for that endpoint. This results in ingress-nginx not being able to reload the config which later leads to readiness check failures and downtime for all ingresses.Call path:
Expected Behavior
Tracer endpoints do not resolve in a hard fail in nginx. Config file generation catches the failure and disables tracing.
This was attempted by @timmysilv in #6872. The question remains whether this is better caught in the ingress-nginx or nginx-opentracing repos.
Replication
/kind feature
The text was updated successfully, but these errors were encountered: