Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit and e2e tests for ignoring non-service backends #7344

Closed
2 tasks
rikatz opened this issue Jul 13, 2021 · 5 comments · Fixed by #7545
Closed
2 tasks

Improve unit and e2e tests for ignoring non-service backends #7344

rikatz opened this issue Jul 13, 2021 · 5 comments · Fixed by #7545
Assignees
@RenatoBrittoAraujo @Debanitrkl
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@rikatz
Copy link
Contributor

rikatz commented Jul 13, 2021 •
edited
Loading

After PR #7332 @cpanato remembered me that I forgot to ask for unit and e2e tests 🤦‍♂️

As a follow up, those tests needs to be created:

  • Create unit tests for cases where the backend exists, but not the Service field
  • Create e2e tests for the same scenario, where an Ingress without a valid service backend should point to default backend

I'm marking this as a good first issue, first serving is the owner. If you wanna deal with this issue, please do a "/assign" as a comment and make sure no one else is dealing with this.

PLEASE LEAVE THIS ISSUE FOR FIRST TIME CONTRIBUTORS!

If you assign yourself into this issue and got stuck into something, please reach us in #ingress-nginx-dev at k8s slack.

/kind cleanup
/good-first-issue
/help
@k8s-ci-robot
Copy link
Contributor

@rikatz:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

After PR #7332 @cpanato remembered me that I forgot to ask for unit and e2e tests 🤦‍♂️

As a follow up, those tests needs to be created:

  • Create unit tests for cases where the backend exists, but not the Service field
  • Create e2e tests for the same scenario, where an Ingress without a valid service backend should point to default backend

I'm marking this as a good first issue, first serving is the owner. If you wanna deal with this issue, please do a "/assign" as a comment and make sure no one else is dealing with this.

If you assign yourself into this issue and got stuck into something, please reach us in #ingress-nginx-dev at k8s slack.

/kind cleanup
/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 13, 2021
@Debanitrkl
Copy link
Member

/assign

@RenatoBrittoAraujo
Copy link
Contributor

Hi! Is this issue being developed or is it stale @Debanitrkl? If it's stale, I would like to take it, if possible.

@RenatoBrittoAraujo RenatoBrittoAraujo mentioned this issue Aug 16, 2021
Closed
@Debanitrkl
Copy link
Member

@RenatoBrittoAraujo yes you could take it

@RenatoBrittoAraujo
Copy link
Contributor

/assign

RenatoBrittoAraujo added a commit to GCES-Kubernetes/ingress-nginx that referenced this issue Aug 24, 2021
@RenatoBrittoAraujo @AGoretti @KalebeLopes
Add e2e test for backend nil service and add nil safeguard (kubernete…
e213667 
…s#7344)

Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>
@MarcosNBJ MarcosNBJ mentioned this issue Aug 25, 2021
Closed
8 tasks
MarcosNBJ pushed a commit to GCES-Kubernetes/ingress-nginx that referenced this issue Aug 25, 2021
@RenatoBrittoAraujo @AGoretti
@KalebeLopes @MarcosNBJ
Add e2e test for backend nil service and add nil safeguard (kubernete…
2d76d50 
…s#7344)

Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>
@MarcosNBJ MarcosNBJ mentioned this issue Aug 25, 2021
Merged
8 tasks
k8s-ci-robot pushed a commit that referenced this issue Aug 26, 2021
@MarcosNBJ @RenatoBrittoAraujo
@AGoretti @KalebeLopes @rikatz @gabrielalbino
Improving e2e tests for non-service backends #7544 (#7545)
638a938 
* Adding test cases for backend with nil service

Signed-off-by: Marcos <marcosnery.comp@gmail.com>
Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>

* Add e2e test for backend nil service and add nil safeguard (#7344)

Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>

* changing portuguese names to english in order to maintain the pattern

* updating boilerplate header

* adding second test case to also test valid path

Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com>

* Updating boilerplate

* fixing boilerplate

Signed-off-by: MarcosN <marcosnery.comp@gmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Gabriel Albino <enggabrielalbino@gmail.com>

* Improving template test for cases where a nil backend service is included

Signed-off-by: MarcosN <marcosnery.comp@gmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Gabriel Albino <enggabrielalbino@gmail.com>

Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>
Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com>
Co-authored-by: Gabriel Albino <enggabrielalbino@gmail.com>
@RenatoBrittoAraujo RenatoBrittoAraujo mentioned this issue Sep 9, 2021
Merged
8 tasks
rchshld pushed a commit to joomcode/ingress-nginx that referenced this issue May 19, 2023
@MarcosNBJ @RenatoBrittoAraujo
@AGoretti @KalebeLopes @rikatz @gabrielalbino @rchshld
Improving e2e tests for non-service backends kubernetes#7544 (kuberne…
effae9b 
…tes#7545)

* Adding test cases for backend with nil service

Signed-off-by: Marcos <marcosnery.comp@gmail.com>
Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>

* Add e2e test for backend nil service and add nil safeguard (kubernetes#7344)

Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>

* changing portuguese names to english in order to maintain the pattern

* updating boilerplate header

* adding second test case to also test valid path

Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com>

* Updating boilerplate

* fixing boilerplate

Signed-off-by: MarcosN <marcosnery.comp@gmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Gabriel Albino <enggabrielalbino@gmail.com>

* Improving template test for cases where a nil backend service is included

Signed-off-by: MarcosN <marcosnery.comp@gmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Gabriel Albino <enggabrielalbino@gmail.com>

Co-authored-by: Renato Araujo <renatobritto@protonmail.com>
Co-authored-by: André Goretti <andremotta96@gmail.com>
Co-authored-by: Kalebe Lopes <calbkalebe@gmail.com>
Co-authored-by: Ricardo Katz <rikatz@users.noreply.github.com>
Co-authored-by: Gabriel Albino <enggabrielalbino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RenatoBrittoAraujo RenatoBrittoAraujo

@Debanitrkl Debanitrkl

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
4 participants
@rikatz @k8s-ci-robot @RenatoBrittoAraujo @Debanitrkl