-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request tag for controller-v0.50.0/deploy/static/provider/kind/deploy.yaml #8240
Comments
@kevinlinglesas: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… On Sun, Feb 13, 2022 at 10:57 PM Kubernetes Prow Robot < ***@***.***> wrote:
@kevinlinglesas <https://github.com/kevinlinglesas>: This issue is
currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will
accept it by applying the triage/accepted label and provide further
guidance.
The triage/accepted label can be added by org members by writing /triage
accepted in a comment.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository.
—
Reply to this email directly, view it on GitHub
<#8240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWROTIQ4SKKA45Q7WWDU27SYJANCNFSM5OJLPYUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
; Long Wu Yuan
|
Please close the issue if solved |
Thank you @longwuyuan for that legacy branch reference. I believe that deploy.yaml will work. However, there's another aspect to this request that I didn't elaborate on well initially. Automated tools that are currently leveraging other tagged controller versions via https://raw.githubusercontent.com/kubernetes/ingress-nginx with programable NGINX_VERSION env variable would desire to also be able to do this for v0.50.0 version. For example one can |
v0.50.0 was/is the last release of the legacy edition.
I think that is why it is missing that version number.
Can you fork and try to put a symlink and then try to open from your fork.
I don't even know if symlink works. If it does then quick PR can be done.
But since it is the last legacy release, you could even instrument your
tooling to just use "legacy" one time change. As there will not be changes
anymore
…On Mon, Feb 14, 2022 at 9:39 PM Kevin Lingle ***@***.***> wrote:
Thank you @longwuyuan <https://github.com/longwuyuan> for that legacy
branch reference. I believe that deploy.yaml will work. However, there's
another aspect to this request that I didn't elaborate on well initially.
Automated tools that are currently leveraging other tagged controller
versions via https://raw.githubusercontent.com/kubernetes/ingress-nginx
with programable NGINX_VERSION env variable would desire to also be able to
do this for v0.50.0 version.
For example one can curl -L "
https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v$NGINX_VERSION/deploy/static/provider/kind/deploy.yaml"
> deploy.yaml when NGINX_VERSION=0.49.3, but not when NGINX_VERSION=0.50.0.
I was thinking there might be value to the community if the latter were
possible.
—
Reply to this email directly, view it on GitHub
<#8240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWWWRRIRJIDSKQGDUWDU3ESKVANCNFSM5OJLPYUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
; Long Wu Yuan
|
the legacy branch is where all the available legacy deployment scripts. We are not planning to release legacy deployments on the main branch. /close |
@strongjz: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is it possible to establish a deploy/static/provider/kind/deploy.yaml that deploys ingress-nginx controller @ v0.50.0?
I was hoping to pick up fix for issue #7939.
The text was updated successfully, but these errors were encountered: