Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Ingress history from kubernetes/contrib #10

Merged
merged 278 commits into from
Nov 10, 2016

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 10, 2016

aledbf and others added 30 commits March 29, 2016 19:15
Improve nginx-ingress-controller documentation.
Update Ingress status information in nginx controller
Fix for `error validating data: expected type array, for field spec.tls, got map; if you choose to ignore these errors, turn validation off with --validate=false`
The DaemonSet as it exists causes the pod to crash on startup with the following:

Error syncing pod, skipping: failed to "StartContainer" for "nginx-ingress-lb" with RunContainerError: "runContainer: API error (500): Cannot start container 7eab41694a7d817665337724b5710bd17d7846f0212408aa9d6056e3211447a4: [8] System error: exec: \"/nginx-ingress-controller-lb\": stat /nginx-ingress-controller-lb: no such file or directory\n"

Modifying the arguments to match the replication controller works.
Updated with correction for Ingress TLS spec
Fix daemonset arguments to match replication controller
Kubernetes Submit Queue and others added 4 commits November 3, 2016 09:39
Automatic merge from submit-queue

Make map_hash_bucket_size configurable

I was getting an error while trying to run the nginx controller in minikube.  This allows this nginx configuration option to be passed in through a configmap.  

The default value depends on the processor's cache line size (32 | 64 | 128), however ServerNameHashBucketSize is determined similarly, so I've set it to the same default (64).

Fixes kubernetes#1817

ref kubernetes/minikube#611

cc @bprashanth
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@aledbf
Copy link
Member Author

aledbf commented Nov 10, 2016

@bprashanth no changes here. This is to keep the history from the ingress directory located in kubernetes/contrib repository

@bprashanth
Copy link
Contributor

LGTM, I think you need to re-cla.
This is just vendors and controllers/nginx,gce right?

@bprashanth bprashanth self-assigned this Nov 10, 2016
@aledbf
Copy link
Member Author

aledbf commented Nov 10, 2016

This is just vendors and controllers/nginx,gce right?

yes. No changes from the current contrib master, just a filtered git copy

I think you need to re-cla.

good question. This failure is not related to my code it appears "aledbf authorized" and this is existing code. I'm not sure if this is a valid warning.

@bprashanth
Copy link
Contributor

Ah, well then

@bprashanth bprashanth merged commit 098bcb5 into kubernetes:master Nov 10, 2016
@aledbf aledbf deleted the history branch November 10, 2016 21:42
VincentGuoCQ pushed a commit to VincentGuoCQ/ingress-nginx that referenced this pull request Jan 4, 2021
…s send to canary service (kubernetes#10)

Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
hanxueluo pushed a commit to hanxueluo/ingress-nginx that referenced this pull request Jan 11, 2021
…anary service (kubernetes#10)

Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
@zoemac11 zoemac11 mentioned this pull request May 10, 2021
Alvaro-Campesino added a commit to Alvaro-Campesino/ingress-nginx-k8s that referenced this pull request Sep 1, 2022
…g race conditions due to vault response time (kubernetes#10)

* fix changelog

* only download cert if not in disk
Alvaro-Campesino added a commit to Alvaro-Campesino/ingress-nginx-k8s that referenced this pull request Jan 16, 2023
…g race conditions due to vault response time (kubernetes#10)

* fix changelog

* only download cert if not in disk
Alvaro-Campesino added a commit to Alvaro-Campesino/ingress-nginx-k8s that referenced this pull request Jan 24, 2023
…g race conditions due to vault response time (kubernetes#10)

* fix changelog

* only download cert if not in disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.