Ignore instance group deletion error when in-use #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
nikhiljindal
reviewed
Aug 2, 2017
| @@ -130,11 +130,15 @@ func (i *Instances) DeleteInstanceGroup(name string) error { | |||
| } | |||
| for _, zone := range zones { | |||
| if err := i.cloud.DeleteInstanceGroup(name, zone); err != nil { | |||
| if !utils.IsHTTPErrorCode(err, http.StatusNotFound) { | |||
| if utils.IsNotFoundError(err) { | |||
| glog.V(3).Infof("Instance group %v in zone %v did not exist", name, zone) | |||
There was a problem hiding this comment.
Not in this PR, but we should standardize our logs. At some places we use ("instance group %v/%v", zone, name) and at some places we use ("instance group %v in zone %v", name, zone)
|
lgtm |
This was referenced Aug 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the last ingress is deleted, the controller needs to gracefully fail when the instance groups are being used by ILBs.