Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotations: print error and skip if malformed #108

Closed
wants to merge 2 commits into from
Closed

annotations: print error and skip if malformed #108

wants to merge 2 commits into from

Commits on Jan 5, 2017

  1. annotations: print error and skip if malformed 

    Logging annotation errors at v5 effectively means that errors are
silent.

In addition, continuing to setup an ingress rule *after* a malformed
authentication, rate limit, or whitelist annotation was noticed seems
a bit bad.
If a user typoes the value of an annotation, they don't deserve to be
left in a horribly insecure state, merely in a broken one.
    @euank
    euank committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    8b80616 View commit details
    Browse the repository at this point in the history

  2. annotations: more consistent error handling

    @euank
    euank committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    6523372 View commit details
    Browse the repository at this point in the history