Add 404 server #1128
Merged
Add 404 server #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
@jonpulsifer just one question: we need to go dependencies? |
|
@aledbf I suppose not, but that will require a number of adjustments (godeps etc). IMO we should do it in another PR for clarity's sake. I tried to do a quick patch but it looks like it'll take me more than 10 minutes, I don't really have time this morning 😨 This is essentially just a |
makes sense |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@jonpulsifer thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1072 and absorbs 404-server.
This is in the spirit of kubernetes-retired/contrib#762
Removal in contrib: kubernetes-retired/contrib#2719