Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos #11935

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix minor typos #11935

merged 1 commit into from
Sep 6, 2024

Conversation

NathanBaulch
Copy link
Contributor

What this PR does / why we need it:

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully), just 72 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • configutations (4)
  • contenating (3)
  • alghoritm (3)
  • instanciates (3)
  • sepecial (2)
  • namesapce (2)
  • unexpeted (2)
  • alghoritms (2)
  • secons (2)
  • capabilites (2)
  • teest (2)
  • excempted (2)
  • localtion (2)
  • its (2)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @NathanBaulch!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added area/docs needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/helm Issues or PRs related to helm charts needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @NathanBaulch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/lua Issues or PRs related to lua code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit d6864b1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66d8ff77665dab000895788d

@strongjz
Copy link
Member

strongjz commented Sep 6, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NathanBaulch, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4f23049 into kubernetes:main Sep 6, 2024
50 checks passed
@Gacko
Copy link
Member

Gacko commented Sep 6, 2024

/triage accepted
/kind bug
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Sep 6, 2024
@Gacko
Copy link
Member

Gacko commented Sep 6, 2024

/cherry-pick release-1.10

@Gacko
Copy link
Member

Gacko commented Sep 6, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: #11935 failed to apply on top of branch "release-1.10":

Applying: Fix typos
error: patch failed: docs/user-guide/third-party-addons/opentelemetry.md:65
error: docs/user-guide/third-party-addons/opentelemetry.md: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	.github/workflows/zz-tmpl-k8s-e2e.yaml
A	changelog/controller-1.11.0.md
M	docs/e2e-tests.md
M	internal/ingress/controller/config/config.go
M	internal/ingress/resolver/mock.go
M	pkg/apis/ingress/types.go
M	test/e2e/framework/framework.go
Patch failed at 0001 Fix typos
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: #11935 failed to apply on top of branch "release-1.11":

Applying: Fix typos
error: patch failed: docs/user-guide/third-party-addons/opentelemetry.md:65
error: docs/user-guide/third-party-addons/opentelemetry.md: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	.github/workflows/zz-tmpl-k8s-e2e.yaml
M	docs/e2e-tests.md
M	internal/ingress/controller/config/config.go
M	internal/ingress/resolver/mock.go
M	pkg/apis/ingress/types.go
M	test/e2e/framework/framework.go
Patch failed at 0001 Fix typos
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@NathanBaulch
Copy link
Contributor Author

Let me know if you'd like me to manually cherry pick this into the two release branches @Gacko 👍

@Gacko
Copy link
Member

Gacko commented Sep 6, 2024

No, it's fine. Gonna do that, no worries.

@NathanBaulch NathanBaulch deleted the typos branch September 6, 2024 21:08
This was referenced Sep 6, 2024
@Gacko
Copy link
Member

Gacko commented Sep 6, 2024

Done! Actually it was only the controller changelog for v1.11.0 missing in the release-1.10 branch - obviously. For release-1.11 I didn't have any conflicts. Strange...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants