refactor controllers.go #1356
Closed
refactor controllers.go #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/L
hzxuzhonghu
commented
Sep 14, 2017
| } | ||
|
|
||
| if len(upstreams[upstreamName].Endpoints) == 0 { | ||
| endps, err := ic.serviceEndpoints(svcKey, backend.ServicePort.String(), hz) |
There was a problem hiding this comment.
previously here panic. Now I pass extensions.IngressBackend as a param to cover 2 cases
|
conflict resolved |
|
Coverage increased (+0.06%) to 44.256% when pulling 0cc028e2530c608e7356324984ac6ea6a0210d16 on hzxuzhonghu:example into 9126ec4 on kubernetes:master. |
hzxuzhonghu
force-pushed
the
example
branch
from
0cc028e
to
371f898
Compare
k8s-ci-robot
added
size/M
|
@aledbf would you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix panic for previous pr #1345