-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an upstream-hash-by annotation to support consistent hashing by nginx variable or text #1490
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3157ce0
to
59ef5ac
Compare
59ef5ac
to
b6569af
Compare
Coverage increased (+0.01%) to 43.783% when pulling b6569af37dfaef5147e46c860193daf7e968d010 on methodmissing:upstream-hash-by into ab3afe5 on kubernetes:master. |
93fe334
to
f3d56e3
Compare
Coverage increased (+0.04%) to 33.505% when pulling f3d56e38299eaabac51364d7ed526a3d1004e679 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master. |
Coverage decreased (-0.0005%) to 33.467% when pulling f3d56e38299eaabac51364d7ed526a3d1004e679 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master. |
f3d56e3
to
f964243
Compare
…g by nginx variable or text
f964243
to
d607cf6
Compare
/lgtm |
@methodmissing thanks! |
This PR consolidates the changesets from 2 distinct fork PRs:
Generates the following: