Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an upstream-hash-by annotation to support consistent hashing by nginx variable or text #1490

Merged
merged 1 commit into from
Oct 7, 2017

Conversation

methodmissing
Copy link
Contributor

This PR consolidates the changesets from 2 distinct fork PRs:

Generates the following:

host:test user$ kubectl describe ing -n something-staging
Name:            something-web
Namespace:        something-staging
Address:        X.X.X.X
Default backend:    default-http-backend:80 (Y.Y.Y.Y:8080)
TLS:
  star-something terminates something-staging.something.com
Rules:
  Host                    Path    Backends
  ----                    ----    --------
  something-staging.something.com    
                             something-web:80 (<none>)
Annotations:
  auth-realm:        blah bblah
  auth-secret:        something-basic-auth
  auth-type:        basic
  upstream-hash-by:    $request_uri <<<<<<<<<<<<<<<<<<<<<<<<<<<
upstream something-staging-something-web-80 {
        # Load balance algorithm; empty for round robin, which is the default
        least_conn;

        hash $request_uri consistent; <<<<<<<<<<<<<<<<<<<<
        server Y.Y.Y.Y:8000 max_fails=0 fail_timeout=0;
}

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 6, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.783% when pulling b6569af37dfaef5147e46c860193daf7e968d010 on methodmissing:upstream-hash-by into ab3afe5 on kubernetes:master.

@methodmissing methodmissing force-pushed the upstream-hash-by branch 3 times, most recently from 93fe334 to f3d56e3 Compare October 7, 2017 10:18
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 33.505% when pulling f3d56e38299eaabac51364d7ed526a3d1004e679 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0005%) to 33.467% when pulling f3d56e38299eaabac51364d7ed526a3d1004e679 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 33.582% when pulling d607cf6 on methodmissing:upstream-hash-by into 7ffa0ae on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Oct 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2017
@aledbf
Copy link
Member

aledbf commented Oct 7, 2017

@methodmissing thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants