Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated ssl_client_cert. add ssl_client_verify header #1511

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

auhlig
Copy link
Contributor

@auhlig auhlig commented Oct 9, 2017

(1) The ssl_client_cert header is deprecated. Use ssl_client_escaped_cert instead. Reference
(2) Setting the ssl-client-verify header allows client certificate verification. See docs

…lient_verify to enable client certificate verification.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 33.492% when pulling 788eb58 on sapcc:sso into 1f269d4 on kubernetes:master.

@rikatz
Copy link
Contributor

rikatz commented Oct 9, 2017

LGTM.

@auhlig does the new $ssl_client_escaped_cert; changes the Cert format passed to the backend? Will the apps using this variable need to be changed, or this is the same behaviour as the old one?

@aledbf
Copy link
Member

aledbf commented Oct 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2017
@aledbf aledbf merged commit 63155ee into kubernetes:master Oct 9, 2017
@auhlig auhlig deleted the sso branch November 22, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants