Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update defaultbackend tag #1568

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Oct 22, 2017

What this PR does / why we need it:
update defaultbackend tag
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #1569
Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 33.403% when pulling db731c5 on zouyee:cluster-loadbalancing into 5c01633 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Oct 22, 2017

@zouyee this is failing because 1.4 is not published. I opened #1569 to fix this

@aledbf aledbf self-assigned this Oct 22, 2017
@aledbf aledbf closed this Oct 24, 2017
@aledbf aledbf reopened this Oct 24, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 33.49% when pulling db731c5 on zouyee:cluster-loadbalancing into 5c01633 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Oct 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2017
@aledbf
Copy link
Member

aledbf commented Oct 24, 2017

@zouyee thanks!

@aledbf aledbf merged commit 0dab51d into kubernetes:master Oct 24, 2017
@dghubble
Copy link

Where does the source for gcr.io/google_containers/defaultbackend live? Is there a release note?

@aledbf
Copy link
Member

aledbf commented Oct 24, 2017

@dghubble
Copy link

dghubble commented Oct 24, 2017

Oh nevermind, don't mind me. Just saw that. Thanks!

dghubble added a commit to poseidon/typhoon that referenced this pull request Oct 26, 2017
justaugustus pushed a commit to justaugustus/typhoon-azure that referenced this pull request Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants