Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pass access scheme in signin url #1587

Merged
merged 2 commits into from
Oct 25, 2017
Merged

Use pass access scheme in signin url #1587

merged 2 commits into from
Oct 25, 2017

Conversation

philipbjorge
Copy link
Contributor

What this PR does / why we need it:
The rd parameter is requesting a redirect to an http path even though the original request was over https

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2017
@philipbjorge philipbjorge changed the title WIP: Use pass access scheme in signin url Use pass access scheme in signin url Oct 25, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 33.352% when pulling 214e13c on philipbjorge:patch-2 into 61d32ae on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Oct 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2017
@aledbf
Copy link
Member

aledbf commented Oct 25, 2017

@philipbjorge thanks!

@aledbf aledbf merged commit f8c2fb9 into kubernetes:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@philipbjorge @k8s-reviewable @coveralls @aledbf @k8s-ci-robot