Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add cors headers when enabled #1696

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Always add cors headers when enabled #1696

merged 1 commit into from
Nov 12, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 12, 2017 •
edited
Loading

What this PR does / why we need it:

fixes #1683
fixes #1679

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 12, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.851% when pulling e7d412c on aledbf:cors-headers into 96e6e04 on kubernetes:master.

@aledbf aledbf merged commit d7f72ad into kubernetes:master Nov 12, 2017
@aledbf aledbf deleted the cors-headers branch November 12, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nginx.tmpl] Cors add_header always CORS headers are not added on 4xx and 5xx responses
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot