Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Core() is deprecated use CoreV1() instead. #1701

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

oilbeater
Copy link
Contributor

Replace Core() as it is deprecated.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@oilbeater oilbeater force-pushed the fix/remove_deprecated branch from 2c965e2 to b3cec74 Compare November 13, 2017 15:45
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 13, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 36.765% when pulling 2c965e290740672da13568fe6d0ebdda948e928c on oilbeater:fix/remove_deprecated into 94487ca on kubernetes:master.

@aledbf aledbf self-assigned this Nov 13, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.803% when pulling b3cec74 on oilbeater:fix/remove_deprecated into 94487ca on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Nov 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2017
@aledbf
Copy link
Member

aledbf commented Nov 13, 2017

@oilbeater thanks!

@aledbf aledbf merged commit 1e0760c into kubernetes:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants