Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes ssl-client-cert header #1734

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Changes ssl-client-cert header #1734

merged 1 commit into from
Nov 20, 2017

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Nov 20, 2017

What this PR does / why we need it: Changes ssl-client-cert from $ssl_client_raw_cert to $ssl_client_escaped_cert

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1714

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.08% when pulling e93c75f on rikatz:patch-1 into adfbc8c on kubernetes:master.

Copy link

@ppknap ppknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rikatz !

@aledbf
Copy link
Member

aledbf commented Nov 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2017
@aledbf
Copy link
Member

aledbf commented Nov 20, 2017

@rikatz thanks!

@aledbf aledbf merged commit 419fe52 into kubernetes:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: ssl-client-cert header optional when using client cert authentication
6 participants