Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config-map usage and options to Documentation #1747

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

diazjf
Copy link

@diazjf diazjf commented Nov 23, 2017

Adds information on how to deploy and use a config-map in order to overwrite default nginx-controller configuration options. It cleans-up and adds more to the possible configuration options and their defaults.

Adds information on how to deploy and use a config-map in order to
overwrite default nginx-controller configuration options. It cleans-up
and adds more to the possible configuration options and their defaults.
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 23, 2017
@aledbf
Copy link
Member

aledbf commented Nov 23, 2017

@diazjf thank you for doing this. Please check the items you added in the docs in this list #1532

@diazjf diazjf mentioned this pull request Nov 23, 2017
24 tasks
@aledbf
Copy link
Member

aledbf commented Nov 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2017
@aledbf
Copy link
Member

aledbf commented Nov 23, 2017

@diazjf thanks!

@aledbf aledbf merged commit 4027da3 into kubernetes:master Nov 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 37.216% when pulling 30c15c3 on diazjf:ssl-cipher into cdbb9bd on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants