Fix SSL Passthrough template issue and custom ports in redirect to HTTPS #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/S
|
Is this fix released? I'm running into this issue with |
|
@aknuds1 yes, in master |
|
@aledbf By released, I meant as in a published image. I guess not? |
|
@aknuds1 no, we are going to release a new version by the end of the week |
|
@aledbf this is a critical fix, can we back merge this to 0.9.0? Thanks! |
|
@gyliu513 I am sorry but I don't have the bandwidth to maintain multiple versions. If you need this in 0.9.0 you need to port the PR in your fork and use a custom image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes:
fixes #1830 #1788