Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS max age annotation #1888

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Add CORS max age annotation #1888

merged 3 commits into from
Jan 9, 2018

Conversation

sagikazarmark
Copy link
Contributor

What this PR does / why we need it: Currently the Access-Control-Max-Age header cannot be changed when CORS requests are enabled and by default it's set to a very high value which is ignored by browsers. This PR makes the header configurable using annotations.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1881

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 9, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2018
@sagikazarmark sagikazarmark changed the title Cors max age Add CORS max age annotation Jan 9, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 9, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 36.698% when pulling b6651fa on sagikazarmark:cors-max-age into 983b994 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 36.698% when pulling b6651fa on sagikazarmark:cors-max-age into 983b994 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 36.75% when pulling b6651fa on sagikazarmark:cors-max-age into 983b994 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jan 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2018
@aledbf aledbf merged commit 313fdd2 into kubernetes:master Jan 9, 2018
@sagikazarmark sagikazarmark deleted the cors-max-age branch January 9, 2018 12:07
@sagikazarmark
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve caching preflight CORS requests
5 participants