Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback #1854 #1969

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Rollback #1854 #1969

merged 1 commit into from
Jan 24, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 24, 2018

Which issue this PR fixes:

fixes #1957

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.492% when pulling 313f808 on aledbf:1854 into c67e918 on kubernetes:master.

@aledbf aledbf merged commit fb3a317 into kubernetes:master Jan 24, 2018
@aledbf aledbf deleted the 1854 branch January 24, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

308 redirect loop when setting "force-ssl-redirect" to "true"
4 participants