Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit-request-status-code option #2001

Merged
merged 3 commits into from
Jan 30, 2018

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 30, 2018

This PR adds configmap option to configure limit_req_status code. The nginx directive is set at the http level. It is set to 503 by default. (http://nginx.org/en/docs/http/ngx_http_limit_req_module.html#limit_req_status)

fixes #1955

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 30, 2018
@coveralls
Copy link

coveralls commented Jan 30, 2018

Coverage Status

Coverage increased (+0.01%) to 39.56% when pulling 1273479 on aramase:limit-request-status into b020686 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jan 30, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Jan 30, 2018

@aramase thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, aramase

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2018
@aledbf aledbf merged commit 2f700a9 into kubernetes:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Config to set status code for request rejected because of limit
5 participants