Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx_cookie_flag_module #2021

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Add nginx_cookie_flag_module #2021

merged 1 commit into from
Feb 8, 2018

Conversation

Stono
Copy link
Contributor

@Stono Stono commented Feb 1, 2018

Hey,
This PR adds the nginx_cooke_flag_module which could then be used in snippet blocks to control cookie policy, enabling users for example to globally set the HttpOnly flag for example

This helps people to improve the security of their proxied applications.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2018
@Stono
Copy link
Contributor Author

Stono commented Feb 1, 2018

/assign @aledbf

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 39.742% when pulling dc164fc on Stono:master into aa59c53 on kubernetes:master.

@Stono
Copy link
Contributor Author

Stono commented Feb 2, 2018

Any thoughts on this one @aledbf ?
I want to be able to do this:

screen shot 2018-02-02 at 19 48 37

@aledbf
Copy link
Member

aledbf commented Feb 8, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Feb 8, 2018

@Stono thanks!

@aledbf aledbf merged commit d76ea2c into kubernetes:master Feb 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Stono

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants