Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCB config to build defaultbackend #2125

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

rvkubiak
Copy link
Contributor

Uses Google Container Builder to build and push the defaultbackend
image. This will be used for automated builds of Kubernetes addon
images.

Uses Google Container Builder to build and push the defaultbackend
image.  This will be used for automated builds of Kubernetes addon
images.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #2125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2125   +/-   ##
=======================================
  Coverage   36.59%   36.59%           
=======================================
  Files          68       68           
  Lines        4837     4837           
=======================================
  Hits         1770     1770           
  Misses       2799     2799           
  Partials      268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809aab7...aa16886. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Feb 21, 2018

/assign @nicksardo

@nicksardo nicksardo added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2018
@aledbf
Copy link
Member

aledbf commented Feb 28, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, rvkubiak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Feb 28, 2018

@nicksardo thanks for the review

@aledbf aledbf merged commit 8ddb610 into kubernetes:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants