Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated log level to v2 for sysctlFSFileMax. #2137

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Updated log level to v2 for sysctlFSFileMax. #2137

merged 1 commit into from
Feb 23, 2018

Conversation

gyliu513
Copy link
Contributor

This is very importatnt log for trouble-shooting, we should update
it to v2 by default.

/cc @aledbf

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

This is very importatnt log for trouble-shooting, we should update
it to v2 by default.
@k8s-ci-robot k8s-ci-robot requested a review from aledbf February 23, 2018 15:29
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 23, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2018
@aledbf
Copy link
Member

aledbf commented Feb 23, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2018
@codecov-io
Copy link

Codecov Report

Merging #2137 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2137   +/-   ##
=======================================
  Coverage   36.59%   36.59%           
=======================================
  Files          68       68           
  Lines        4837     4837           
=======================================
  Hits         1770     1770           
  Misses       2799     2799           
  Partials      268      268
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 3.95% <0%> (ø) ⬆️
internal/ingress/controller/util.go 39.13% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309a794...b831552. Read the comment docs.

@aledbf aledbf merged commit f26c881 into kubernetes:master Feb 23, 2018
@gyliu513 gyliu513 deleted the log-level branch February 24, 2018 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants