Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to disable logs in a location #2144

Merged
merged 2 commits into from
Feb 25, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 25, 2018

Which issue this PR fixes:

fixes #2087

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2018
@aledbf aledbf force-pushed the disable-access-log branch from ac818b7 to 1734796 Compare February 25, 2018 13:54
@codecov-io
Copy link

codecov-io commented Feb 25, 2018

Codecov Report

Merging #2144 into master will increase coverage by <.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2144      +/-   ##
==========================================
+ Coverage   36.53%   36.53%   +<.01%     
==========================================
  Files          68       69       +1     
  Lines        4845     4861      +16     
==========================================
+ Hits         1770     1776       +6     
- Misses       2807     2815       +8     
- Partials      268      270       +2
Impacted Files Coverage Δ
internal/ingress/types_equals.go 12.75% <0%> (-0.09%) ⬇️
internal/ingress/controller/controller.go 0% <0%> (ø) ⬆️
internal/ingress/annotations/annotations.go 85.45% <100%> (+0.26%) ⬆️
internal/ingress/annotations/log/main.go 45.45% <45.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb3be6...005bfe0. Read the comment docs.

@aledbf aledbf force-pushed the disable-access-log branch from 1734796 to f9f4946 Compare February 25, 2018 14:18
@aledbf aledbf merged commit 0dee303 into kubernetes:master Feb 25, 2018
@aledbf aledbf deleted the disable-access-log branch February 25, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable-access-log at the ingress level
4 participants