Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about secure-verify-ca-secret #2169

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

maxlaverse
Copy link
Contributor

The annotation nginx.ingress.kubernetes.io/secure-verify-ca-secret was introduced (#716) without any documentation.

This adds a few sentences about it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2018
@maxlaverse
Copy link
Contributor Author

/assign @nicksardo

@codecov-io
Copy link

Codecov Report

Merging #2169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2169   +/-   ##
=======================================
  Coverage   36.45%   36.45%           
=======================================
  Files          69       69           
  Lines        4861     4861           
=======================================
  Hits         1772     1772           
  Misses       2819     2819           
  Partials      270      270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164bb7b...99c506d. Read the comment docs.

@nicksardo nicksardo assigned aledbf and unassigned nicksardo Mar 5, 2018
@aledbf
Copy link
Member

aledbf commented Mar 5, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Mar 5, 2018

@maxlaverse thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, maxlaverse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2018
@aledbf aledbf merged commit 3130665 into kubernetes:master Mar 5, 2018
@maxlaverse maxlaverse deleted the secure_doc branch March 5, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants