Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic configuration when custom errors are enabled #2212

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 19, 2018

Which issue this PR fixes:

fixes #2211

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2018
@aledbf aledbf changed the title Fix bin data Fix dynamic configuration when custom errors are enabled Mar 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #2212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2212   +/-   ##
=======================================
  Coverage   36.98%   36.98%           
=======================================
  Files          70       70           
  Lines        4978     4978           
=======================================
  Hits         1841     1841           
  Misses       2857     2857           
  Partials      280      280
Impacted Files Coverage Δ
internal/file/bindata.go 51.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de30e53...8c1d489. Read the comment docs.

@aledbf aledbf merged commit 6b7491f into kubernetes:master Mar 19, 2018
@aledbf aledbf deleted the fix-bin-data branch March 19, 2018 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to start ingress controller 0.12.0
3 participants