Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect servers bug #2248

Closed
wants to merge 1 commit into from

Conversation

oilbeater
Copy link
Contributor

@oilbeater oilbeater commented Mar 23, 2018

What this PR does / why we need it:
The key-value place for origin server and redirect server is wrong
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2230

Special notes for your reviewer:

the key-value place for origin server and redirect server is wrong fix kubernetes#2247
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oilbeater
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: caseydavenport

Assign the PR to them by writing /assign @caseydavenport in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #2248 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2248      +/-   ##
==========================================
- Coverage   37.13%   37.11%   -0.02%     
==========================================
  Files          71       71              
  Lines        5025     5025              
==========================================
- Hits         1866     1865       -1     
- Misses       2874     2876       +2     
+ Partials      285      284       -1
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 5.13% <0%> (ø) ⬆️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e099c5...9831814. Read the comment docs.

@oilbeater oilbeater closed this Mar 24, 2018
@oilbeater oilbeater deleted the fix/wrong-redirect branch March 27, 2018 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from-to-www-redirect not working with a wildcard
3 participants