Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aggregate] Fix typos across codebase #2368

Merged
merged 2 commits into from
Jun 25, 2018
Merged

[aggregate] Fix typos across codebase #2368

merged 2 commits into from
Jun 25, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Apr 17, 2018

What is this for?

I suggest using this aggregate (editable by maintainers) as an effort to reduce the number of PRs dedicated to fixing (usually) small amounts of typos across the codebase, and therefore keep the commit history clean while preserving commits ownership by contributors.

I will myself try to spare time within the next few days and go through comments and documentation pages in order to fix as many typos as possible. I will keep aggregating new purely typo-related issues and PRs here.

Procedure

$ git fetch origin pull/<ID>/head:tmp-typo
$ git cherry-pick tmp-typo

Commits by the same author will be squashed before merging.

Aggregated issues/PRs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2018
@aledbf aledbf added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2018
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 17, 2018
@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #2368 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2368   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files          74       74           
  Lines        5077     5077           
=======================================
  Hits         2070     2070           
  Misses       2724     2724           
  Partials      283      283
Impacted Files Coverage Δ
cmd/nginx/main.go 22.62% <ø> (ø) ⬆️
internal/ingress/controller/nginx.go 11.51% <0%> (ø) ⬆️
cmd/nginx/flags.go 83.33% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbd2d6...48a64c4. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 8, 2018

@antoineco friendly ping

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2018
@antoineco
Copy link
Contributor Author

@aledbf good that you remind me. I parked this after the massive changes to the documentation which invalidated 3 commits out of 5 :) Will push my changes package by package.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2018
@antoineco
Copy link
Contributor Author

@aledbf as changes to the cmd package are quite consequent (they do change user-facing strings) I opened a separate PR especially for these.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2018
@aledbf
Copy link
Member

aledbf commented Jun 11, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2018
@antoineco
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2018
@antoineco
Copy link
Contributor Author

@aledbf I'd say this can be merged, there hasn't been a high rate of submission for typo-fixing PRs :)

@aledbf
Copy link
Member

aledbf commented Jun 24, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c0ed143 into kubernetes:master Jun 25, 2018
@antoineco antoineco deleted the fix-typos branch July 2, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants