-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aggregate] Fix typos across codebase #2368
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2368 +/- ##
=======================================
Coverage 40.77% 40.77%
=======================================
Files 74 74
Lines 5077 5077
=======================================
Hits 2070 2070
Misses 2724 2724
Partials 283 283
Continue to review full report at Codecov.
|
@antoineco friendly ping |
@aledbf good that you remind me. I parked this after the massive changes to the documentation which invalidated 3 commits out of 5 :) Will push my changes package by package. |
@aledbf as changes to the |
/approve |
/hold cancel |
@aledbf I'd say this can be merged, there hasn't been a high rate of submission for typo-fixing PRs :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is this for?
I suggest using this aggregate (editable by maintainers) as an effort to reduce the number of PRs dedicated to fixing (usually) small amounts of typos across the codebase, and therefore keep the commit history clean while preserving commits ownership by contributors.
I will myself try to spare time within the next few days and go through comments and documentation pages in order to fix as many typos as possible. I will keep aggregating new purely typo-related issues and PRs here.
Procedure
Commits by the same author will be squashed before merging.
Aggregated issues/PRs