Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tls section without hosts in Ingress rule #2398

Merged
merged 1 commit into from
Apr 22, 2018
Merged

Allow tls section without hosts in Ingress rule #2398

merged 1 commit into from
Apr 22, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 21, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 21, 2018
@codecov-io
Copy link

codecov-io commented Apr 21, 2018 •
edited
Loading

Codecov Report

Merging #2398 into master will increase coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2398      +/-   ##
==========================================
+ Coverage   39.45%   39.52%   +0.06%     
==========================================
  Files          73       73              
  Lines        5216     5225       +9     
==========================================
+ Hits         2058     2065       +7     
  Misses       2870     2870              
- Partials      288      290       +2
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.07% <77.77%> (+2.07%) ⬆️
cmd/nginx/main.go 21.37% <0%> (-4.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8179dfe...04ed2d9. Read the comment docs.

@ElvinEfendi
Copy link
Member

no test? :)

@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 21, 2018
@aledbf
Copy link
Member Author

aledbf commented Apr 21, 2018

no test? :)

done 😄

@aledbf aledbf force-pushed the empty-tls branch 2 times, most recently from ff7030d to 3d5ec77 Compare April 22, 2018 00:01
ElvinEfendi
ElvinEfendi reviewed Apr 22, 2018
View reviewed changes
internal/ingress/controller/controller_test.go Outdated
@@ -0,0 +1,131 @@
/*
Copyright 2017 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@ElvinEfendi
Copy link
Member

The first test for controller.go 🎉

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2018
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 27fcee4 into kubernetes:master Apr 22, 2018
@aledbf aledbf deleted the empty-tls branch April 22, 2018 03:49
@jaredallard
Copy link

It looks like this doesn't work if you utilize spec.hosts and reverts to supplying the fake TLS cert instead. Is this intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

Assignees

@ElvinEfendi ElvinEfendi

@antoineco antoineco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aledbf @codecov-io @ElvinEfendi @k8s-ci-robot @jaredallard @antoineco