Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve build-dev-env.sh script #2443

Merged
merged 1 commit into from
Apr 29, 2018
Merged

improve build-dev-env.sh script #2443

merged 1 commit into from
Apr 29, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
The diff is self explanatory.

Which issue this PR fixes: n/a

Special notes for your reviewer: n/a

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@codecov-io
Copy link

Codecov Report

Merging #2443 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   41.61%   41.61%           
=======================================
  Files          74       74           
  Lines        5291     5291           
=======================================
  Hits         2202     2202           
  Misses       2792     2792           
  Partials      297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fce01...73dec94. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Apr 29, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 451c695 into kubernetes:master Apr 29, 2018
@ElvinEfendi ElvinEfendi deleted the improve-dev-en branch April 29, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants